♻️ Use the Core OpenQASM serializer - #436
Draft
simon1hofmann wants to merge 1 commit into
Draft
Conversation
12 tasks
simon1hofmann
force-pushed
the
codex/2098-openqasm-serializer
branch
from
August 26, 2026 11:14
0722c5b to
9546f7f
Compare
simon1hofmann
marked this pull request as ready for review
August 26, 2026 13:25
denialhaag
requested changes
Aug 26, 2026
denialhaag
left a comment
Member
There was a problem hiding this comment.
Thanks for also updating the implementation here, @simon1hofmann! 😎
I just have two comments, both of which depend on the other two reviews:
simon1hofmann
marked this pull request as draft
August 26, 2026 14:24
simon1hofmann
force-pushed
the
codex/2098-openqasm-serializer
branch
from
August 26, 2026 14:38
9546f7f to
0a0c8b9
Compare
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Migrate projective-assertion compilation to the operation-level serializer
introduced by MQT Core #2249.
Operation::dumpOpenQASM2calls withqc::OpenQASMSerializer;s/sdgpath in the compilation test.Draft status
This PR intentionally remains a draft until MQT Core v4 is released. It does
not pin an intermediate Core commit and does not add temporary MLIR/CI setup.
CI is therefore expected to fail against the currently released Core version.
Dependencies
and the corresponding MQT Core v4 release.
Validation
Validated against the Core PR branch before removing the temporary pin:
uvx nox -s lintAI assistance
Codex materially assisted with implementation, tests, integration validation,
and this pull request description. A human must review and understand the
changes before marking this pull request ready.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).