Skip to content

Linux: condense mime-type definitions - #34428

Open
creativecoder wants to merge 2 commits into
musescore:mainfrom
creativecoder:linux-condense-mimetypes
Open

Linux: condense mime-type definitions#34428
creativecoder wants to merge 2 commits into
musescore:mainfrom
creativecoder:linux-condense-mimetypes

Conversation

@creativecoder

@creativecoder creativecoder commented Jul 31, 2026

Copy link
Copy Markdown

Resolves: #15922

Condenses Linux mime-type definitions

  • Removes duplicate application/x-musescore+xml declaration, moving both globs under a single mime-type
  • Removes duplicate application/x-musescore for backup files, putting both *.mscz and *.mscz~ globs under one mime-type
  • Fixes file extension typo, correcting mscsx to mscs

NOTE: this removes the "MuseScore compressed backup score" label from Linux file managers for .mscz~ files and replaces it with the regular "MuseScore File".

Because backup files are the same format as standard score files, I don't think they should have a separate mime-type. If the behavior of opening them needs to be different, I think that should be handled at the application layer.

  • I signed the CLA as grantmk:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

@creativecoder creativecoder changed the title Linux: condense mimetype definitions Linux: condense mime-type definitions Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The compressed MuseScore MIME type now matches *.mscz~ backup files. The uncompressed MuseScore MIME type now matches *.mscs files. Duplicate *.mscsx and compressed-backup declarations were removed.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes combine duplicate MIME declarations and correct the extension typo, addressing issue #15922 by improving Linux score-file identification.
Out of Scope Changes check ✅ Passed All changes are limited to the Linux MuseScore MIME definitions and directly support the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and concisely describes the main change to condense Linux MIME-type definitions.
Description check ✅ Passed The description identifies the issue, explains the changes and impact, and completes the required checklist except for the optional test item.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Lazerbeak12345

Copy link
Copy Markdown

I just wanted to add, there is some prior work in Arch Linux. The distro packages a downstream fix not unlike yours. I don't expect this to change anything about this PR, however.

@mathesoncalum

Copy link
Copy Markdown
Contributor

I signed the CLA as username

Hi - please insert your musescore.org username here. Thanks.

@creativecoder

Copy link
Copy Markdown
Author

Hi - please insert your musescore.org username here. Thanks.

@mathesoncalum , sorry about that--fixed now.

Comment thread buildscripts/packaging/Linux+BSD/musescore.xml.in Outdated
<mime-type type="application/x-musescore+xml">
<comment>MuseScore Uncompressed File</comment>
<glob pattern="*.mscx"/>
<glob pattern="*.mscs"/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given how different mscs files are from mscx files, I would say they deserve their own new MIME type (it's unlike those backup files, which have identical file structure). I must say I don't immediately have inspiration for a good name for such MIME type though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSCZ files listed as "MuseScore compressed backup score" in Linux file managers

5 participants