Linux: condense mime-type definitions - #34428
Conversation
📝 WalkthroughWalkthroughThe compressed MuseScore MIME type now matches 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I just wanted to add, there is some prior work in Arch Linux. The distro packages a downstream fix not unlike yours. I don't expect this to change anything about this PR, however. |
@mathesoncalum , sorry about that--fixed now. |
| <mime-type type="application/x-musescore+xml"> | ||
| <comment>MuseScore Uncompressed File</comment> | ||
| <glob pattern="*.mscx"/> | ||
| <glob pattern="*.mscs"/> |
There was a problem hiding this comment.
Given how different mscs files are from mscx files, I would say they deserve their own new MIME type (it's unlike those backup files, which have identical file structure). I must say I don't immediately have inspiration for a good name for such MIME type though...
Resolves: #15922
Condenses Linux mime-type definitions
application/x-musescore+xmldeclaration, moving both globs under a singlemime-typeapplication/x-musescorefor backup files, putting both*.msczand*.mscz~globs under onemime-typemscsxtomscsNOTE: this removes the "MuseScore compressed backup score" label from Linux file managers for
.mscz~files and replaces it with the regular "MuseScore File".Because backup files are the same format as standard score files, I don't think they should have a separate mime-type. If the behavior of opening them needs to be different, I think that should be handled at the application layer.