Skip to content

Limit leading space and line thicknesses #34449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sundialrise wants to merge 3 commits into
base: main
Choose a base branch
from
+18 −1
Open

Limit leading space and line thicknesses #34449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
446c322
Limit leading space so it cannot move elements left off page
sundialrise Jul 21, 2026
a343ded
Set limits to beam, staff line, and barline thickness
sundialrise Jul 28, 2026
a712044
Don't waste time allocating a variable for page margin
sundialrise Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/engraving/rendering/score/horizontalspacing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "dom/glissando.h"
#include "dom/lyrics.h"
#include "dom/note.h"
#include "dom/page.h"
#include "dom/rest.h"
#include "dom/score.h"
#include "dom/stemslash.h"
Expand Down Expand Up @@ -290,6 +291,10 @@ std::vector<HorizontalSpacing::SegmentPosition> HorizontalSpacing::spaceSegments

double leadingSpace = curSeg->extraLeadingSpace().toAbsolute(ctx.spatium);
placedSegments.back().xPosInSystemCoords += leadingSpace;
Page* page = toPage(ctx.system->parent());
if (page) {
placedSegments.back().xPosInSystemCoords = std::max(placedSegments.back().xPosInSystemCoords, -page->lm());
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

if (curSeg->isChordRestType()) {
bool isFirstCROfSystem = curSeg->rtick().isZero() && curSeg->measure()->isFirstInSystem();
Expand Down
2 changes: 1 addition & 1 deletion src/notationscene/qml/MuseScore/NotationScene/styledialog/BeamsPage.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ StyledFlickable {
currentValue: beamsPageModel.beamWidth.value

minValue: 0
maxValue: 99
maxValue: 1
step: 0.01
decimals: 2
measureUnitsSymbol: qsTrc("global", "sp")
Expand Down
12 changes: 12 additions & 0 deletions src/notationscene/widgets/editstyle.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,9 @@
<property name="suffix">
<string extracomment="spatium unit">sp</string>
</property>
<property name="maximum">
<double>1.000000000000000</double>
</property>
Comment thread
coderabbitai[bot] marked this conversation as resolved.
<property name="singleStep">
<double>0.100000000000000</double>
</property>
Expand Down Expand Up @@ -4967,6 +4970,9 @@
<property name="singleStep">
<double>0.010000000000000</double>
</property>
<property name="maximum">
<double>2.000000000000000</double>
</property>
</widget>
</item>
<item row="1" column="0" colspan="2">
Expand Down Expand Up @@ -5036,6 +5042,9 @@
<property name="singleStep">
<double>0.010000000000000</double>
</property>
<property name="maximum">
<double>2.000000000000000</double>
</property>
</widget>
</item>
<item row="6" column="0">
Expand Down Expand Up @@ -5181,6 +5190,9 @@
<property name="singleStep">
<double>0.010000000000000</double>
</property>
<property name="maximum">
<double>2.000000000000000</double>
</property>
</widget>
</item>
<item row="8" column="0">
Expand Down
Loading