Skip to content

Linux file picker fix - #34484

Open
embarc-gabriel wants to merge 2 commits into
musescore:mainfrom
embarc-gabriel:linux-file-picker-fix
Open

Linux file picker fix#34484
embarc-gabriel wants to merge 2 commits into
musescore:mainfrom
embarc-gabriel:linux-file-picker-fix

Conversation

@embarc-gabriel

@embarc-gabriel embarc-gabriel commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

After the fixes on musescore/muse_framework#199 we should change (experimental) to [experimental] to avoid the former to be considered an extension filter on the linux file picker.

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The muse submodule reference now points to commit d605d80a30a138cb8fb09b0258793bf889ca2ebd. Project save and open dialogs now use [experimental] in relevant file-format labels. File extensions and supported formats remain unchanged.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The experimental-label changes are not clearly required to make AU4 preset filters include .txt and appear unrelated to issue #8166. Remove the unrelated label changes, or explain how each change is required for the Linux native file picker fix.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ❓ Inconclusive The provided diff does not show that AU4 preset filters now include .txt as required by issue #8166. Provide the relevant submodule diff or test evidence that Linux native file picker imports expose AU4 preset files with the .txt filter.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: a fix for Linux file-picker behavior.
Description check ✅ Passed The description explains the Linux file-picker issue and completes the required checklist; the test checkbox is left unchecked where testing may not apply.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@embarc-gabriel
embarc-gabriel force-pushed the linux-file-picker-fix branch from dad0dd4 to 2ce7744 Compare August 6, 2026 12:35
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@embarc-gabriel
embarc-gabriel force-pushed the linux-file-picker-fix branch from 2ce7744 to 4e71c99 Compare August 6, 2026 12:53
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@DmitryArefiev DmitryArefiev self-assigned this Aug 6, 2026
@DmitryArefiev

Copy link
Copy Markdown
Contributor

Tested on LinuxUbuntu26.04.4 LTS, Kubuntu 26.04. No regressions found

#17563 is FIXED in this PR

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saving a score without file extension saves the file as a folder, not as a mscz file.

5 participants