fixed creation of bend/dive when grace note already existed before th…

[alexpavlov96]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f900e0e3-10c0-435f-b51f-22cbd55b4daa

📥 Commits

Reviewing files that changed from the base of the PR and between 58ae0e3 and 079642c.

📒 Files selected for processing (5)

• src/engraving/editing/cmd.cpp
• src/importexport/guitarpro/tests/guitarbendimporter_data/dive_return_up_glissando-gp.mscx
• src/importexport/guitarpro/tests/guitarbendimporter_data/predive_with_grace-gp.mscx
• src/importexport/guitarpro/tests/guitarbendimporter_data/predive_with_grace.gp
• src/importexport/guitarpro/tests/guitarbendimporter_tests.cpp

---

📝 Walkthrough

Walkthrough

Score::addGuitarBend now reuses a preceding grace chord only when it contains a bend or dive ghost note. Otherwise, it creates an appoggiatura grace note. Guitar Pro importer fixtures update grace-chord structure and linked bend, glissando, and slur elements. A regression test covers a pre-dive bend combined with a grace note.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided, so the required motivation, issue reference, checklist, and testing details are missing.	Add a description with the issue reference, change motivation, completed checklist items, testing details, and any relevant information about prior attempts.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the fix for bend and dive creation when a grace note already exists.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}