Standardize widget back button and remove kyper ChevronLeft icon - #358
Standardize widget back button and remove kyper ChevronLeft icon#358mwclemy wants to merge 5 commits into
Conversation
mwclemy
changed the title
| padding: `0px 8px`, | ||
| width: '44px', | ||
| container: { flexGrow: 1 }, | ||
| appBar: { backgroundColor: tokens.BackgroundColor.Container, display: 'flex' }, |
There was a problem hiding this comment.
We should be using css modules for styling.
| width={tokens.Spacing.Large} | ||
| /> | ||
| </IconButton> | ||
| <Box data-test="navigation-header" sx={defaultStyles.container}> |
There was a problem hiding this comment.
Go back button is used in multiple places. Are we intending for this App bar to show up everywhere that GoBackButton is rendered?
There was a problem hiding this comment.
For consistency and maintainability I would say yes. There is no visual difference that the AppBar adds if you look at the screenshots I shared. To me having a single Back button defined and used across the entire experience makes the most sense. @platypus801 what do you think?
There was a problem hiding this comment.
The GoBackButton is used in 4 places including DayOfMonth picker. I'm doubtful that you want the appbar for the day of month picker
There was a problem hiding this comment.
This is how it looks on my branch:
vs on master:
You can't really tell the difference.
There was a problem hiding this comment.
Maybe just a slight space at the top.
2 participants
Before
After