Repository navigation
Seed an unconfirmed aircraft - #352
Open
oskarbarcz wants to merge 3 commits into
Open
oskarbarcz wants to merge 3 commits into
oskarbarcz wants to merge 3 commits into
Conversation
Lufthansa gains D-AIXP, an A350-900 seeded the way a SimBrief import creates one: unconfirmed, the operator's default livery, no SELCAL, base or cabin. A fresh local stack now shows the unconfirmed state without running an import first. Lufthansa's seeded fleet summary becomes nine aircraft of types A339 and A359.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fleet coverage test asked every seeded type for curated hold data. An import can add an aircraft of any type, and D-AIXP is seeded as one, an A350-900 with no curated hold. It goes on its own list, next to the degraded-path fixture, so the rest of the fleet is still checked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OpenTofu plan for
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh local stack had no unconfirmed aircraft, so the Unconfirmed badge and Confirm correctness (mypreflight/app#363) only showed after running a SimBrief import first. This seeds one.
The commit was written for #347, but it was pushed to that branch after #347 had merged, so it never reached
main. It's cherry-picked here unchanged.What changes
isConfirmed: false, the operator's default livery (Lufthansa 2026), no SELCAL, base or cabin.aircraft.list.featurelists D-AIXP.fleet-coverage.spec.tsasked every seeded type for curated hold data. An import can add any type, so D-AIXP's A359 goes on a newIMPORTED_UNCURATED_TYPESlist next to theB762degraded-path fixture, and every other fleet type is still checked. I didn't invent A350 hold data to make it pass, because the curated holds are real data only.mainafter Let pilots import their own SimBrief plan and check in with its estimated times #348, List only the signed-in pilot's flights, and name the cities in the SimBrief preview #349 and Remove a flight that was checked in but not boarded for 24 hours #350 merged.Checked
lintandtest(1449) exit 0 on the final commit. The first unit run on the seed alone caught the two hold-coverage tests above.test:functionalpassed all 1624 scenarios with the seed.format: the whole repo is clean except its usual local.impeccablecache warning, a file git excludes and CI never sees.prisma db pushand the seed ran as part of the suite's reset.Knowledge base: nothing to add, since #76 already describes aircraft from imports.
🤖 Generated with Claude Code