fix: Pass charset/Security into ErrorHandler mock controller bootstrap - #559
Merged
hellopablo merged 1 commit intoSep 7, 2026
Conversation
pocketarc/codeigniter requires CI_Security($charset) and CI_Input(CI_Security). instantiateMockController() was still calling load_class() with no args, causing ArgumentCountError while rendering fatal error screens after the get_instance() guard change.
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fatal error screens cascade into a second fatal:
Stack:
ErrorHandler::instantiateMockController()→load_class('Security', 'core').Cause
pocketarc/codeigniterrequires:CI_Security::__construct($charset)CI_Input::__construct(CI_Security &$security)and boots them as:
instantiateMockController()still called both with no args. This became reachable after therenderErrorView()guard changed fromCI_Lang/MX_Langtoget_instance()(FormValidation/Translation work).Fix
Pass charset into Security and the Security instance into Input, matching CodeIgniter’s bootstrap.
Follow-up
Bump consuming apps’
composer.lockonce this lands onfeature/pre-new-admin.