Skip to content

Remove legacy MFA from auth - #546

Merged
hellopablo merged 4 commits into
developfrom
feat/remove-legacy-mfa
Sep 23, 2026
Merged

hellopablo merged 4 commits into
developfrom
feat/remove-legacy-mfa

Conversation

@hellopablo

@hellopablo hellopablo commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Stop resetting security questions and authenticator devices from the admin user form. That MFA now lives in module-multi-factor-auth.
  • Remove auth's own question and device challenge from login and password reset, including the abandoned sonata-project/google-authenticator dependency.
  • Drop the leftover question, device, and token tables. Cherry-pick this onto feature/pre-new-admin with the same migration number so an app moving between the branches runs it once.

The login-method signal stays. module-multi-factor-auth reads it to skip its own challenge after a user-verified passkey login.

Test plan

  • Log in with a password and confirm there is no redirect to auth/mfa/question or auth/mfa/device
  • Complete forgotten-password and temporary/expired password reset without a security question or device code
  • Edit a user in admin and confirm the Security tab only shows the password fields
  • Run migrations and confirm user_auth_two_factor_question, user_auth_two_factor_token, user_auth_two_factor_device_secret, and user_auth_two_factor_device_code are dropped
  • With module-multi-factor-auth installed, confirm a password login is still challenged and a user-verified passkey login is not

Security questions and authenticator devices are no longer reset from the user edit form, because that MFA now lives in module-multi-factor-auth.
Login and password reset no longer challenge with auth's own security questions or authenticator devices, and the abandoned Google Authenticator dependency goes with them.
Apps that already migrated to module-multi-factor-auth should not keep the old question, device, and token rows.
Both branches will carry this as migration 23, so it does not need to run on every migrate.
@hellopablo
hellopablo merged commit 78985f5 into develop Sep 23, 2026
5 checks passed
@hellopablo
hellopablo deleted the feat/remove-legacy-mfa branch September 23, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant