Remove legacy MFA from auth - #546
Merged
Merged
Conversation
Security questions and authenticator devices are no longer reset from the user edit form, because that MFA now lives in module-multi-factor-auth.
Login and password reset no longer challenge with auth's own security questions or authenticator devices, and the abandoned Google Authenticator dependency goes with them.
Apps that already migrated to module-multi-factor-auth should not keep the old question, device, and token rows.
Both branches will carry this as migration 23, so it does not need to run on every migrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
module-multi-factor-auth.sonata-project/google-authenticatordependency.feature/pre-new-adminwith the same migration number so an app moving between the branches runs it once.The login-method signal stays.
module-multi-factor-authreads it to skip its own challenge after a user-verified passkey login.Test plan
auth/mfa/questionorauth/mfa/deviceuser_auth_two_factor_question,user_auth_two_factor_token,user_auth_two_factor_device_secret, anduser_auth_two_factor_device_codeare droppedmodule-multi-factor-authinstalled, confirm a password login is still challenged and a user-verified passkey login is not