chore: Cherry-pick cdnObjectPickerMulti* validation rules onto develop - #458
Merged
Conversation
…odule Ports `cdnObjectPickerMultiObjectRequired`, `cdnObjectPickerMultiLabelRequired` and `cdnObjectPickerMultiAllRequired` from `nails/common` as auto-discovered `Nails\Cdn\Validation\Rule` classes with the same string names, and adds matching `RULE_*` constants. Requires the CodeIgniter-free FormValidation in `nails/common`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit ff63c10)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks the CDN object-picker validation rules from
feature/pre-new-admin, ports rules that used to live innails/commonto auto-discoveredNails\Cdn\Validation\Ruleclasses. Depends only on the base validation engine in nails/common#558 (AbstractRule/Context), not on theValidatorsubclass work.fb5e207(ff63c10) feat: Provide thecdnObjectPickerMulti*validation rules from the moduleConflicts resolved
src/Constants.php: trivial —develophad independently addedMEDIA_MANAGER_V1_URL/MEDIA_MANAGER_V2_URLconsts next to the same block this commit addsRULE_*consts to. Merged both in.Verification
This module has no
vendor/(not composer-installed locally) and no existing test files, so I could only lint the new/changed files — all clean. No PHPUnit/PHPStan run possible here without a fullcomposer install, which felt disproportionate for a self-contained 4-file addition that mirrors the exact pattern of the equivalent rules already reviewed incommon.Do not merge yet — holding for review.
🤖 Generated with Claude Code