feat: upgrade MediaManagerV2 to Vue 3 - #460
Merged
Merged
Conversation
Migrate Media Manager V2 off Vue 2.7 onto Vue 3 via Asset::vue3(). - Bump vue to ^3.5.24 and vue-loader to ^17.4.2; drop vue-template-compiler - Mount with createApp/h instead of new Vue - Update custom v-model to modelValue/update:modelValue - Rename beforeDestroy → beforeUnmount; replace $set and _uid - Split MultiSelect v-for/v-if onto separate nodes - Rebuild admin assets Co-authored-by: Pablo de la Peña <pablo@hellopablo.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade Media Manager V2 from Vue 2.7 to Vue 3 so we can use
vue-loader17 (and stay aligned withnails/commonAsset::vue3()).This supersedes the incompatible Dependabot bump in #439 and makes the Dependabot ignore approach in #459 unnecessary for this path.
Changes
vue^3.5.24,vue-loader^17.4.2; removevue-template-compiler$oAsset->vue2()→vue3()on the MMV2 admin pagenew Vue({ el, render })→Vue.createApp(...).mount(...)with Vue 3h()propsmodelValue/update:modelValue,beforeUnmount, drop$set/_uid, fix MultiSelectv-for+v-ifadmin.min.js/admin.min.cssOut of scope
nails/module-admin’s separate Vue 2.6 appCompatibility note
nails/commonforbids loading Vue 2 and Vue 3 CDN libs on the same page. MMV2 now requests Vue 3 only via Asset.Test plan
yarn buildsucceeds with vue-loader 17nails/commonvue3())