Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions assets/css/admin.mediamanager-v2.min.css

Large diffs are not rendered by default.

20 changes: 0 additions & 20 deletions assets/css/admin.min.css

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions assets/js/admin.mediamanager-v2.min.js

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions assets/js/admin.min.js

Large diffs are not rendered by default.

10 changes: 8 additions & 2 deletions assets/js/components/MediaManagerV2.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import MediaManagerV2Vue from '../components-vue/MediaManagerV2.vue';

class MediaManagerV2 {
constructor(adminController) {
this.adminController = adminController;
Expand All @@ -24,9 +22,17 @@ class MediaManagerV2 {
const mountPoint = document.querySelector('#nails-module-cdn-media-manager-v2');
if (mountPoint) {
try {
// Vue is loaded after module admin.min.js (Asset libraries come last).
// Vue 3 SFCs import from 'vue' at module eval time, so load them only
// after the CDN global is available — unlike Vue 2 / vue-loader 15.
const Vue = await this.waitForVue();
this.adminController.log('Mounting MediaManagerV2');

const { default: MediaManagerV2Vue } = await import(
/* webpackChunkName: "admin.mediamanager-v2" */
'../components-vue/MediaManagerV2.vue'
);

// Get switch back URL from mount point
const switchBackUrl = mountPoint.dataset.switchBackUrl || '';

Expand Down
14 changes: 12 additions & 2 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ module.exports = {
},
output: {
filename: '[name].min.js',
path: path.resolve(__dirname, 'assets/js/')
chunkFilename: '[name].min.js',
path: path.resolve(__dirname, 'assets/js/'),
// Resolve async chunks relative to this script's URL
// (e.g. /vendor/nails/module-cdn/assets/js/)
publicPath: 'auto'
},
module: {
rules: [
Expand Down Expand Up @@ -40,11 +44,17 @@ module.exports = {
},
plugins: [
new MiniCssExtractPlugin({
filename: '../css/[name].min.css'
filename: '../css/[name].min.css',
chunkFilename: '../css/[name].min.css'
}),
new VueLoaderPlugin(),

],
// Keep the MediaManagerV2 async import as a single stable chunk
// (avoid hashed vendor split chunks like 621.min.js)
optimization: {
splitChunks: false
},
externals: {
vue: 'Vue'
},
Expand Down
Loading