fix(ios): always invoke WebKit completion handlers - #32
Open
NathanWalker wants to merge 1 commit into
Open
Conversation
WKWebView wraps every decision/completion handler in a CompletionHandlerCallChecker whose destructor raises an ObjC exception if the handler was never called. Under NativeScript the block is owned by a JS wrapper, so the exception is thrown from inside a later V8 GC and aborts the app with SIGABRT far away from the code that dropped the handler. Three paths never called their handler: - decidePolicyForNavigationAction: the Cancel call sat inside an `if (Trace.isEnabled())` block, so cancelling a navigation from shouldOverrideUrlLoading leaked the handler in every build with tracing off. The `!url` early return leaked it too. - runJavaScriptAlert/Confirm/TextInputPanel: `_webAlert`/`_webConfirm`/ `_webPrompt` return false when the app registers no listener, and the missing-owner path returned early — both left the handler uncalled, so any page calling alert()/confirm()/prompt() could abort the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WKWebView contains every decision/completion handler in a CompletionHandlerCallChecker whose destructor raises an ObjC exception if the handler was never called. Under NativeScript the block is owned by a JS wrapper, so the exception is thrown from inside a later V8 GC and aborts the app with SIGABRT far away from the code that dropped the handler.
Three paths never called their handler:
if (Trace.isEnabled())block, so cancelling a navigation from shouldOverrideUrlLoading leaked the handler in every build with tracing off. The!urlearly return leaked it too._webAlert/_webConfirm/_webPromptreturn false when the app registers no listener, and the missing-owner path returned early — both left the handler uncalled, so any page calling alert()/confirm()/prompt() could abort the app.