Repository navigation
fix(sonarr): handle empty response bodies - #10
Merged
Merged
Conversation
… no JSON)
Sonarr replies to DELETE /episodefile/{id} with HTTP 200 and an empty body.
sonarrReq() unconditionally called res.json(), throwing 'Unexpected end of
JSON input' after the delete succeeded — which aborted the try-block before
searchEpisode() ran, so no replacement download was queued.
Now: empty body -> null. Delete + re-search complete in one pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Auto-remediation log showed:
api: failed: Unexpected end of JSON inputSonarr replies to
DELETE /episodefile/{id}with HTTP 200 + empty body.sonarrReq()unconditionally calledres.json(), which threw after the delete had already succeeded — aborting the try-block beforesearchEpisode()ran. Result: corrupt file deleted, but no replacement download queued (only self-healed on the next poll/webhook).Fix
sonarrReq()now reads the body as text first; empty →null. Non-empty still parses as JSON. One-line behaviour change, no API contract change.Test plan
node --check src/sonarr.jsnode --test tests/*.test.js— 4/4 passruntime_too_shortremediation shows delete + re-search both ok