Repository navigation
fix: update PHP images to releases patched against php2shell - #40
Merged
Merged
Conversation
roave/security-advisories now conflicts with php <8.3.36, <8.4.27 and <8.5.12, so the composer-permissions test failed for the 8.3 and 8.4 images still pinned to 8.3.32 and 8.4.23. Renovate never proposed those patch bumps: without separateMinorPatch it only offers the newest non-major version (8.5.x) for every line, which the minor-update rule disables. Enable separateMinorPatch for the PHP images so each line receives its own patch updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI fails on #39 for PHP 8.3 and 8.4.
tests/composer-permissionsinstallsroave/security-advisories:dev-latest, which now conflicts with vulnerable PHP versions (<8.3.36,<8.4.27,<8.5.12).php-images.jsonstill pinned 8.3.32 and 8.4.23, so Composer could not resolve.Renovate never proposed those patch bumps. Without
separateMinorPatchit only offers the newest non-major version (8.5.x) for every line, and that update is disabled by the minor-update rule.Changes
php-images.json: 8.3.36, 8.4.27 and 8.5.12 (index digests).renovate.json5: enableseparateMinorPatchfor the PHP images, so each line gets its own patch PRs. It needs its own rule because it can't be combined withmatchUpdateTypes.Notes
renovate/patch-php-base-images, digest updates stay onrenovate/php-base-images. Both automerge.Verification
task test PHP_VERSION=8.3|8.4|8.5passes locally.renovate-config-validator --strictpasses.