Skip to content

refactor(service): extract pure logic into a Bukkit-free service layer wired via Guice - #17

Merged
nbdSteve merged 10 commits into
masterfrom
fm/armorplus-4e-registries-r9
Jul 24, 2026
Merged

refactor(service): extract pure logic into a Bukkit-free service layer wired via Guice#17
nbdSteve merged 10 commits into
masterfrom
fm/armorplus-4e-registries-r9

refactor(model): move pure-logic classes into a Bukkit-free service l…

5dd4ae2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 24, 2026 in 19s

Annotations

Check failure on line 55 in src/main/java/gg/steve/mc/ap/player/PlayerArmorSetService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=nbdSteve_Carmor&issues=AZ-Oq-Cb3_y5QfimMvS4&open=AZ-Oq-Cb3_y5QfimMvS4&pullRequest=17

Check warning on line 16 in src/main/java/gg/steve/mc/ap/cmd/sub/GiveCmd.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 75 to 64, Complexity from 16 to 14, Nesting Level from 3 to 2, Number of Variables from 14 to 6.

See more on https://sonarcloud.io/project/issues?id=nbdSteve_Carmor&issues=AZ-Oq-CE3_y5QfimMvS3&open=AZ-Oq-CE3_y5QfimMvS3&pullRequest=17