Repository navigation
Drop the pdf-generator-version pin - always install latest - #149
Merged
Merged
Conversation
No docset declares @neo4j-antora/pdf-generator in its own package.json (see this install step's own comment on why), so there's no package-lock entry to go stale either way. Pinning a default version here just meant every fix to that package needed a matching PR (and re-tag) here before any consumer actually got it - this package is still young and evolving quickly, so always installing latest removes that extra step entirely. Individual callers never overrode the old default, so nothing downstream needs to change.
recrwplay
changed the title
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No docset declares
@neo4j-antora/pdf-generatorin its ownpackage.json, so there's nopackage-lock.jsonentry to go stale either way. Pinning a default version here just meant every fix to that package needed a matching PR (andv2re-tag) in this repo before any consumer actually got it - this package is still young and evolving quickly, so always installing latest removes that extra step entirely. No caller overrides the old default, so nothing downstream needs to change.Test plan
npm install "@neo4j-antora/pdf-generator"(no version qualifier) resolves to the current latest (0.1.6) locally.