Repository navigation
tabbed-nav: carry each version's selector text (Current, LTS) into docsets.json - #160
Merged
Merged
Conversation
…csets.json selector-labels sets selectorText on a component version, which the page's version selector shows after the version. Include it in each docsetVersions entry and pass it through to docsets.json, so the docsets modal can show the same markers as the page. Absent for a docset not built since, so a consumer can tell.
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@neo4j-antora/tabbed-navfrom 0.4.1 to 0.4.2.What
Each version in
docsetVersions(on a component's latesttabs.jsonentry) now carriesselectorText, anddocsets.jsonpasses it through to each version:{ "version": "2026.11", "latest": true, "selectorText": "(Current) (LTS)", "url": "/cypher-manual/2026.11/", "pdf": "..." }selectorTextis the text the page's version selector shows after the version. Theselector-labelsextension sets it on each component version:(Current)for the latest version,(LTS)for a version markedlts: truein antora.yml, or both. The docsets modal in docs-ui (docs-restructure) uses it so it shows the same markers as the page, including LTS, which it could not show before.''when a version has no marker, and absent for a docset that has not been built since this change, so a consumer can tell the two apart. The modal falls back to(Current)for the latest version when the field is absent.selector-labelshaving run before tabbed-nav. The docs build adds tabbed-nav last, so it should have.Testing
docsets.jsmerge was checked on sample data: a rebuilt docset keepsselectorText(including''), and an older one has no such field.selector-labelsand tabbed-nav together, so the ordering above is not confirmed against a real build.Rollout
Follow-up
Document
selectorText, along withdocsets.jsonand its attributes, in the docs-playbook tabbed-nav page, frommain.