Conversation
min_version had been left commented out in FloorplanConfig after local testing against a pre-release NetBox feature build, so the plugin never rejected an incompatible (pre-4.7) install. Restore it to match max_version and the compatibility matrix. Cross-checked #106 against this branch: the FloorplanFilterSet.search() FieldError was already fixed here, but FloorplanImageViewSet had no filterset at all, so FloorplanImageFilterSet is added and wired in (matching name/external_url/comments), Floorplan search now also matches the assigned image's name, and FloorplanImage.filename is annotated to silence drf-spectacular type-hint warnings. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Under-indented continuation line in API_TOKEN_PEPPERS was failing CI lint. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
cruse1977
marked this pull request as ready for review
September 18, 2026 11:23
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the 4.7.0 release: NetBox 4.7 support, declarative UI panels, and several bug fixes (see CHANGELOG.md).
Fixes #96, Fixes #100, Fixes #104
Cross-checked against #106 (@cfoellmann): the
FloorplanFilterSet.search()FieldError fix was already here. Picked up two gaps it found —FloorplanImageViewSethad no filterset, andFloorplanImage.filenamelacked a type hint for drf-spectacular.🤖 Generated with Claude Code