Repository navigation
Conversation
SDD-Mutation: v1:8d142be58e9c9fdb910fdf34010cad39a3c4214bac4a2769a61caf278f5d9e2c
Register adds SDD's tools to an mcp.Server the host constructs, beside the host's own tools; Instructions exports the server instructions text. New stays a wrapper that builds a server named sdd and registers onto it. Implements 20261106-232735-d-tac-d3f. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A host composing the shared MCP wrapper can now add tools of its own on the same MCP server and endpoint as SDD's, so agents reach both through one connector (graph entry
20261106-232735-d-tac-d3f).mcpapp.Register(server, opts)adds SDD's 14 tools to an*mcp.Serverthe host constructs. The host owns the server's name and version, instructions, transport, authentication and lifecycle;Registerinstalls no middleware.mcpapp.Instructionsexports SDD's server instructions text for the host to include in its own.mcpapp.Newstays the wrapper for compositions without tools of their own: it builds a server namedsdd, installs the shutdown middleware and registers onto it.Handler,Run,RunStdio,ConnectandShutdownare unchanged, sosdd serveand the external example keep their code.Serveronto a privatetoolSet, independent of the server they are registered on.Register's doc states that host tools must not reuse SDD's tool names (accepted in the directive).The tool-contract snapshot is unchanged.
shutdown_test.gois renamed toshutdown_internal_test.go, since it needs unexported access.The branch also carries the SDD work-in-progress marker commit for the directive; the closing done removes it.
Test plan
register_test.go: a host server with SDD's tools plus a host tool lists both, serves the host's name and instructions starting withmcpapp.Instructions, and drivesstart_sessionand the host tool over one connection;Register(nil, …)failsgo vet ./...,devbox run lint,devbox run test(root andexamples/extendingsdd) green🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Adds
mcpapp.Registerso hosts can serve SDD’s 14 tools alongside their own tools.Acknowledged choices: hlubek explicitly accepts documented tool-name collisions and identifies the WIP marker as intentional.
Reviews (1) · Last reviewed commit: "feat(mcpapp): register SDD's tools onto ..." · Reviewed by Greptile