Skip to content

chore: do not inject css and build pure esm #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Oct 7, 2026
Merged

chore: do not inject css and build pure esm #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 46 additions & 61 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
"type": "module",
"exports": {
"types": "./dist/index.d.ts",
"import": "./dist/index.mjs",
"require": "./dist/index.cjs"
"import": "./dist/index.mjs"
},
"files": [
"dist"
Expand Down Expand Up @@ -93,7 +92,6 @@
"typedoc": "^0.28.20",
"typescript": "^5.9.3",
"vite": "^7.1.11",
"vite-plugin-css-injected-by-js": "^3.5.2",
"vitest": "^3.2.4",
"vue": "^3.5.42",
"vue-tsc": "^3.3.11"
Expand Down
11 changes: 1 addition & 10 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { createLibConfig } from '@nextcloud/vite-config'
import { po as poParser } from 'gettext-parser'
import { readdirSync, readFileSync } from 'node:fs'
import { defineConfig } from 'vite'
import injectCSS from 'vite-plugin-css-injected-by-js'
import { videojsElements } from './build/videojsElements.ts'

const { version } = JSON.parse(readFileSync('./package.json', 'utf8'))
Expand Down Expand Up @@ -67,7 +66,6 @@ export default defineConfig((env) => {
return createLibConfig({
index: 'lib/index.ts',
}, {
libraryFormats: ['es', 'cjs'],
nodeExternalsOptions: {
// for subpath imports like '@nextcloud/l10n/gettext'
include: [/^@nextcloud\//],
Expand All @@ -77,15 +75,8 @@ export default defineConfig((env) => {
// not survive into what we publish.
exclude: [/^vue-material-design-icons\//, /^@mdi\/svg\//],
},
// The styles are carried inside the javascript and injected as it
// runs, each chunk bringing its own. Emitting stylesheets instead
// leaves it to the consuming bundler to link a chunk's CSS when
// that chunk loads, which is not something a library can count on:
// in the server it did not happen, and the lazily loaded viewer
// rendered with none of its styles.
inlineCSS: false,
config: {
plugins: [injectCSS({ relativeCSSInjection: true }), videojsElements],
plugins: [videojsElements],
},

replace: {
Expand Down
Loading