Skip to content

fix(build): have each chunk import its stylesheet #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Oct 8, 2026
Merged

fix(build): have each chunk import its stylesheet #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/components/ImageEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ function onError(error: Error) {

<style scoped>
/* Full-viewport overlay so the editor fills the screen regardless of the
(collapsing) handler container it replaces. */
.viewer__image-editor {
(collapsing) handler container it replaces. Over the editor's own
`.image-editor` rule by specificity, as the app bundling the library may
load that stylesheet after this one. */
.image-editor.viewer__image-editor {
position: fixed;
inset: 0;
z-index: 10102;
Expand Down
4 changes: 4 additions & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ export default defineConfig((env) => {
return createLibConfig({
index: 'lib/index.ts',
}, {
// Each chunk imports its own stylesheet, for the app bundling the
// library to load along with that chunk. Without it the styles are
// emitted but nothing loads them.
inlineCSS: true,
nodeExternalsOptions: {
// for subpath imports like '@nextcloud/l10n/gettext'
include: [/^@nextcloud\//],
Expand Down
Loading