Repository navigation
refactor(media): use the packaged Video.js skins instead of a vendored copy - #138
Merged
Merged
Conversation
…d copy The skins only take their accent from us now, through their public CSS variables, which drops the copied skin source and its templates. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
added
status: review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 92.84% 92.10% -0.74%
==========================================
Files 50 45 -5
Lines 4330 3852 -478
Branches 853 856 +3
==========================================
- Hits 4020 3548 -472
+ Misses 289 283 -6
Partials 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #128: we don't need our own copy of the skin. The packaged
<video-skin>and<audio-skin>take our accent through their public CSS variables, which drops about 5800 lines.The bar and menus keep the Video.js look, and picture-in-picture is back. The skin's controls live in an open shadow root, which is how the speed menu stays localised and the swipe guard still reaches them. The audio speed button is drawn in CSS, so it shows
1.5×whatever the language. The poster after the end is now our own image over the video, since the skin only shows its poster before playback starts.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.