chore(build): update - #2056
Merged
Merged
Conversation
Contributor
alperozturk96
force-pushed
the
update-build-settings
branch
from
June 23, 2026 06:14
5133c86 to
67215ed
Compare
Contributor
alperozturk96
force-pushed
the
update-build-settings
branch
from
July 6, 2026 11:18
67215ed to
a998b9c
Compare
Contributor
alperozturk96
force-pushed
the
update-build-settings
branch
from
July 16, 2026 11:35
a998b9c to
d44186f
Compare
Contributor
alperozturk96
force-pushed
the
update-build-settings
branch
from
July 16, 2026 13:59
d44186f to
ed4a984
Compare
Collaborator
|
stable22-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/2056-IT-stable22-14-30/debug/ |
Contributor
alperozturk96
force-pushed
the
update-build-settings
branch
from
July 17, 2026 08:05
cc8ddcd to
b97f64f
Compare
Contributor
Collaborator
Author
|
only fails due to code ql kotlin version: 
|
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me> # Conflicts: # .github/workflows/assemble.yml # .github/workflows/check.yml # .github/workflows/garm.yml
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
update-build-settings
branch
from
July 21, 2026 07:01
b97f64f to
5d0d4d5
Compare
Contributor
| sourceCompatibility JavaVersion.VERSION_17 | ||
| targetCompatibility JavaVersion.VERSION_17 | ||
| sourceCompatibility JavaVersion.VERSION_21 | ||
| targetCompatibility JavaVersion.VERSION_21 |
Member
There was a problem hiding this comment.
Can this be a problem for any app using our code?
If they are on 17?
Collaborator
Author
There was a problem hiding this comment.
sourceCompatibility = what language we write
targetCompatibility = what language level we produce -> this could break the clients
when i only set the targetCompatibility to 17 ci fails. thus better to keep 17.
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Contributor
tobiasKaminsky
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes