Skip to content

Stable29 - #2274

Closed
karlitschek wants to merge 37 commits into
masterfrom
stable29
Closed

karlitschek wants to merge 37 commits into
masterfrom
stable29

Conversation

@karlitschek

Copy link
Copy Markdown
Member
  • Resolves: #
  • Target version: master

Summary

ArtificialOwl and others added 30 commits October 28, 2024 13:31
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
nextcloud-bot and others added 7 commits April 29, 2025 01:45
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: GitHub <noreply@github.com>
`stable29` cannot build. #2258 took webpack to 5.111.1, and webpack stopped
depending on `terser-webpack-plugin` somewhere after 5.94 --
`@nextcloud/webpack-vue-config` still requires it, so nothing hoists it into
`node_modules` any more and the build dies with
`Cannot find module 'terser-webpack-plugin'` before it reads a single source
file.

It is declared as a devDependency rather than pinned through an override,
because it is a direct requirement of the webpack config this app uses. It was
only ever satisfied by accident, through a transitive dependency of webpack
that has since gone. `^5.6.1` is the current 5.x, the major
`@nextcloud/webpack-vue-config` expects.

Verified with a clean `npm ci` followed by `npm run build` on this branch: the
bundle compiles, where on `stable29` as it stands it does not.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
fix(deps): declare terser-webpack-plugin on stable29
@karlitschek

Copy link
Copy Markdown
Member Author

Closing without merging: stable29 is a maintenance branch at 0.7.0, 1405 commits behind master (now 0.26.59). The 37 commits it carries that master lacks are Transifex translation syncs, an npm audit fix and a terser-webpack-plugin declaration — merging it into master would mean resolving a 180-file conflict between 0.7.0-era code and everything since, with no upside. The branch stays as-is for stable29 maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants