remove automatic port-forwarding as it is not stable - #2846
Merged
Merged
Conversation
szaimen
changed the base branch from
enh/noid/rewrite-pihole-and-pivpn
to
main
September 23, 2026 09:20
Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/remove-automatic-port-forw-
branch
from
September 23, 2026 09:53
c8b5ecb to
f74c805
Compare
szaimen
marked this pull request as ready for review
September 23, 2026 09:54
Collaborator
Author
|
This is now ready for review 👍 |
Member
|
Haha, do you remember when I reviewed this? 😂 |
Collaborator
Author
Not really... Probably a long time ago? :D |
Member
|
Yes, it was years ago! Before the AIO when you and me had it going hard for the VM. I was a bit sceptical but decided to merge anyway. Just thought it was funny that it's now removed. 🤓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)