Skip to content

add updateReferencesFile() - #28

Open
maxulysse wants to merge 8 commits into
mainfrom
references
Open

maxulysse wants to merge 8 commits into
mainfrom
references

Conversation

@maxulysse

Copy link
Copy Markdown
Member

updateReferencesFile() is a new function to help with references.
It replaces a given basepath within a datasheet yaml file into any other given basepath.

@nvnieuwk nvnieuwk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .pre-commit-config.yaml Outdated
Comment thread validation/config-validation/main.nf

@edmundmiller edmundmiller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add end to end Nextflow example workflows for these?

The one's in the docs look good, they're just in the docs so they're not going to run in the tests. 😅

@edmundmiller edmundmiller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at this further. I don't love the concept of letting people rewrite the YAML files on the fly or changing this path; I would rather that die.

I think we can provide them with a YAML script to adjust the YAML to their use case, but I believe that would just end up breaking so many things if we change these as an ad hoc approach.

Do users really want a full mirror of igenomes, or did they just copy a genome or two?

If it's the latter, then I think they should just write their tiny YAML file and move on.

@maxulysse

Copy link
Copy Markdown
Member Author

I'm looking at this further. I don't love the concept of letting people rewrite the YAML files on the fly or changing this path; I would rather that die.

Can we discuss about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants