Skip to content

feat: NITRO_APP_BASE_URL can be used at runtime - #4670

Draft
jvllmr wants to merge 4 commits into
nitrojs:mainfrom
jvllmr:dynamic-base-url
Draft

jvllmr wants to merge 4 commits into
nitrojs:mainfrom
jvllmr:dynamic-base-url

Conversation

@jvllmr

@jvllmr jvllmr commented Sep 26, 2026

Copy link
Copy Markdown

🔗 Linked issue

closes #4381

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is my first draft for the changes discussed in #4381
I will mark this PR as ready once I'm confident enough in the solution for further review and I added sufficient documentation.

General idea is that h3.requestWithBaseUrl is applied on the request if the config setting features.runtimeBaseUrl is set to true.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Signed-off-by: Jan Vollmer <jan@vllmr.dev>
Signed-off-by: Jan Vollmer <jan@vllmr.dev>
@vercel

vercel Bot commented Sep 26, 2026

Copy link
Copy Markdown

@jvllmr is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jvllmr
jvllmr marked this pull request as ready for review September 26, 2026 09:49
@jvllmr
jvllmr requested a review from pi0 as a code owner September 26, 2026 09:49
@jvllmr
jvllmr marked this pull request as draft September 26, 2026 09:50
Signed-off-by: Jan Vollmer <jan@vllmr.dev>
Signed-off-by: Jan Vollmer <jan@vllmr.dev>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow setting baseURL at runtime

1 participant