Repository navigation
Make defaultEcosystemSrc a selection from the tree's sources - #53
Merged
Merged
Conversation
`mkLib`'s `defaultEcosystemSrc` is now a function of `sources` that
returns the source of each ecosystem by its exact name, as
`defaultPkgs` is a function of the package sets:
defaultEcosystemSrc = sources: { nixpkgs-lib = sources.nixpkgs; };
so the sources a tree uses are the sources it pins. mkLib applies it
to `sources` and holds what it selected where it held the attribute
set before, so `ecosystemSrc <name>` and the manifest's
`defaultEcosystemSrc` read as they did. An attribute set is refused,
with the function form in the message.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 21, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mkLib'sdefaultEcosystemSrcis now a function ofsourcesthat returns the source of each ecosystem by its exact name, the waydefaultPkgsis a function of the package sets:So the sources a tree uses are the sources it pins, and the record can name each by the key it is pinned under. mkLib applies the function to
sourcesand keeps the result where it kept the attribute set before, soecosystemSrc <name>and the manifest'sdefaultEcosystemSrcread as they did. An attribute set is refused, with the function form in the message.This is a breaking change for every
mkLibcaller that passesdefaultEcosystemSrc. The companion caisson PR, on caisson's branchfeat/separate-nixpkgs-parts, makesecosystemSrca selection too and stops falling back between thenixpkgs-lib,nixpkgsandnixoskeys. The workspace consumers follow it.Tests. The hermetic tests select their fixtures from
sources. The shape test, nowlifecycleDefaultEcosystemSrcMustBeASelection, checks that a number, an attribute set, and a function returning a non-attribute-set are all refused. The suite passes, 129 tests, and so doesnix flake check.🤖 Generated with Claude Code