Repository navigation
Conversation
…osure-sources A registered overlay or module receives the sources passed to mkLib. mkLib, resolve and the pin readers all call that attribute set `sources`, so the closure argument now carries the same name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #59, which names the pinned trees dependencies and reads them from the closure lib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A file registered through
mkLibOverlay,mkPkgOverlayormkModulereceives the sources that its flake passed tomkLib.mkLib,resolveand the pin readers all call that attribute setsources, but the closure argument that carries it was namedclosure-inputs. This pull request renames the closure argument toclosure-sources, so one word names the attribute set everywhere.The change breaks every registered file that names
closure-inputsin its first argument list. Those files needclosure-sourcesinstead. nix-caisson/caisson#143 makes that change in caisson, and nix-caisson/nix-caisson.github.io#90 makes it in the documentation.This pull request is stacked on #57.
🤖 Generated with Claude Code