Repository navigation
Replace the module symlinks with generic entries - #156
Merged
Merged
Conversation
No path under modules/ is a symlink any more. caisson's options move from modules/generic/core to modules/generic/caisson, and the core module of every class is a real module that imports that entry, as the flake and structural cores already did. The top-level `caisson.checks` option moves to its own generic entry, top-level-checks, which only the cores of classes with a single system import. The flake and structural cores therefore no longer import it and disable it with disabledModules. The modules that several classes shared through symlinks are generic entries: activation-marker, hjem-activation, home-manager-activation and profile-activation (previously under nixos, linked from systemManager and darwin) and drift-warning (previously nvf/default, linked from nixvim/default). The nvf and nixvim default modules import drift-warning. The system-manager-parent alias is gone, and the system-manager default module imports nixos-parent. The registry names of the moved entries change, and the tops export every generic entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No path under
modules/is a symlink after this change.Changes
modules/generic/coretomodules/generic/caisson, with its files in one directory. Thecoremodule of every class is a real module that imports that entry, as theflakeandstructuralcores already did.caisson.checksoption is its own generic entry,top-level-checks. Only the cores of classes with a single system import it, so theflakeandstructuralcores no longer import it and then remove it withdisabledModules.activation-marker,hjem-activation,home-manager-activationandprofile-activation(previously undernixos, linked fromsystemManageranddarwin), anddrift-warning(previouslynvf/default, linked fromnixvim/default). Thenvfandnixvimdefaultmodules importdrift-warning.system-manager-parentalias is removed. The system-managerdefaultmodule importsnixos-parent, which reads a NixOS or a system-manager configuration.genericentry instead of onlycore.Breaking change
The registry names of the moved entries change:
modules.nixos.hjem-activationis nowmodules.generic.hjem-activation, and the same for the other three activation modules,modules.nvf.defaultkeeps its name, andsystem-manager-parentno longer exists inhomeManagerandhjem. I found no use of the old names in the workspace repositories.Checks
Passing locally:
nix-unit,pinned-world,registries,eval-weight,treefmt,hjem-system,module-class-export-success,composition-success,minimal-consumer-success,lib-consumer-chain-success,nixpkgs-consumer-success,pkg-overlays-registry-consumer,pkg-overlays-registry-producer,literate-flake-default,argument-errors,deferred-errorsanddrift-message. The VM checks returned without building anything, so they may not exercise this change.PR #153 edits
modules/generic/core/types.nix, which is nowmodules/generic/caisson/types.nix, so one of the two needs a rebase after the other merges.🤖 Generated with Claude Code