Skip to content

paper: one meaning per symbol, theorems as bounds, references and layout - #115

Merged
nmoinvaz merged 13 commits into
paper/referee-campaignfrom
paper/referee-presentation
Nov 19, 2026
Merged

nmoinvaz merged 13 commits into
paper/referee-campaignfrom
paper/referee-presentation

Conversation

@nmoinvaz

Copy link
Copy Markdown
Owner

Stacked on #114. Fixes the referee's findings on notation, references and presentation: 21, 22, 26, 29, 30, 31, 37, 39, 40, 42, 43, 44 and 45, and what was left of 24.

Statements

Finding 40: Theorems 19, 21, 22, 40 and 42 each stated a recursion. The recursion now stands in an unnumbered paragraph before the theorem ("The constant kappa_DIV", "The constant delta_J", "The constant delta^DD", "The bound of a case", "The bound E(l)"), and the theorem states the bound and its computed value. No hypothesis, bound or constant changes, and the numbering of every theorem, lemma and table is unchanged, so the numbers cited in src/, tests/, the READMEs and the scripts stay correct.

Finding 21: Algorithm 2 now takes N terms c_0, ..., c_(N-1) with N <= n + 1, as Appendix B and Theorem 9 do. It took c_0, ..., c_N with N <= n.

Notation (finding 22)

Symbol Kept for Renamed
Lambda the sum of the L_m RN(1/ln 2) is c_r
beta the part bounds of b in Lemma 13 (1+u)^(n-1)/(1-u) is written out; the accumulator's 1/(1-(n+1)Ku) is Gamma; Lemma 38's is epsilon_k
alpha part bounds Theorem 14's level coefficients are A-hat_m; the double-word bounds are e_A, e_F, e_M, e_P, as the trig appendix's e_op
gamma Theorem 14's carry coefficients the square root's part bounds of g are pi^g; Lemma 38's tail bound is x-bar_t; LOG's value of step (5) is y_c
zeta Theorem 17's |Z|/M the square root's is Z-bar_c; the part bounds are pi-hat^z, pi^s and chi''
pi part bounds the number is upright; the division's two-product errors are w_i
f the float operand Proposition 24's factors are m_1 m_2; MUL's chain writes s_n; LOG's x' - 1 is varphi; Horner's exact coefficients are F^e_k
R, Delta absolute, Lemmas 11 and 13 Theorem 14's normalized ones are R_n, Delta_n

The scripts' docstrings name the paper's symbols; no code name changes. explog_bits.py scan now prints x_0 c_r.

References (findings 37 and 39)

New entries, each checked against Crossref or Open Library: Shewchuk (Discrete Comput. Geom. 18(3), 305-363, 1997), Møller (BIT 5(1), 37-50, 1965), Knuth (TAOCP 2, 3rd ed., ISBN 0-201-89684-2), Sterbenz (Prentice-Hall, ISBN 0-13-322495-3) and Payne and Hanek (SIGNUM Newsl. 18(1), 19-24, 1983). The list is in order of first citation. The three ACM TOMS entries have Crossref's page ranges (1-27, 1-24, 1-34), the Universal entry has the pull request's full title, the crate's entry has its version, commit and date, and the QD entry cites the authors' repository (BL-highprecision/QD, v2.3.24), where I read exp and log to confirm the squarings s = 2s + s^2 and the one Newton step.

Presentation

Findings 26, 29, 30, 31: the cosine's last part is given as u^6 r^2/2, near 2^(-2j-319); the undefined "units of 2^-418" are gone; the exp and ln appendix says how DWTimesDW2 and DWTimesDW3 differ; Table I uses a for every operand and Table II has its row order.

Findings 42 to 45: Figure 1 is redrawn with labels about twice the size, the appendix starts on a new page, Table V lands on the page of its text, two long inline chains are displays, "Assume 6" reads "Under Assumption 6", and the paragraph headings carry no a) to d) labels. I rendered and read pages 1 to 3, 6, 7, 9 to 11, 13, 14, 17, 21 and 22.

Not done

Finding 32, the accumulator's doc in src/od.rs, is outside paper/ and is left alone. The comment at src/trig.rs:630-633 has 2^(-2j-318) and 2^-82 where the paper now has 2^(-2j-319) and the script's 2^-81.

Still unverified

HAL and the ACM Digital Library refuse automated access, so these rest on secondary sources or are unconfirmed:

  • Popescu's Theorems 3.3.4 and 3.4.5 and their leading terms, and what Joldes, Marty, Muller and Popescu state about QD's division;
  • the theorem numbers 3.1 and 7.1 of Joldes, Muller and Popescu (3.1 agrees with NVIDIA's CCCL documentation) and 2.8 of Muller and Rideau, cited in src/ and README.md. Their bounds 3u^2/(1-4u), 2u^2, 5u^2/(1+u)^2, (4u^2 + u^3/2)/(1+u)^2 and 15u^2 + 56u^3 (p >= 7), and the algorithm numbers 4, 6, 7, 9, 11, 12 and 17, agree with the Coq files of Muller and Rideau's formalization as distributed in VeriNum/double-double and with slides of J.-M. Muller;
  • the number of the double-word square root's theorem in Lefèvre et al.: 3.5 is that of the HAL preprint, and one secondary source gives 3.6 for the published article, so the paper now cites it as the preprint's;
  • the year of Sterbenz's book, 1974 in the usual citation and 1973 at Open Library.

Verified here and not before: the QD paper's statements, read in the text of the authors' technical report; the page ranges of the ITP 2017, ARITH-23 and triple-word entries; the ISBN of Cody and Waite.

@nmoinvaz nmoinvaz added the documentation Improvements or additions to documentation label Nov 19, 2026
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 02caa67b-c387-4356-82d9-db0d93733909

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge; no actionable issues were found.

Summary

This PR cleans up the paper’s notation, theorem statements, references and layout without changing the arithmetic implementations or computed bounds.

  • Each paper symbol now points to one quantity.
  • Theorems state bounds after the paper defines their constants.
  • The paper adds source context and presents its examples more clearly.

No actionable issues found. nmoinvaz explicitly deferred the accumulator documentation in src/od.rs and the older exponent comments in src/trig.rs; those are outside this paper-only cleanup.

Reviews (1) · Last reviewed commit: "paper: rebuild the PDF" · Reviewed by Greptile

Lambda, beta, alpha, gamma, zeta, pi and f each stood for several things, and R and Delta were absolute in Lemmas 11 and 13 and normalized in Theorem 14. The appendices rename all but one use of each, write the number pi upright, and the scripts' docstrings name the paper's symbols.
Each of these theorems stated a recursion for computing a bound. The recursion now stands in a paragraph before the theorem, which states the bound and its computed value. The numbering is unchanged.
Algorithm 2 took c_0 to c_N with N at most n, and Appendix B and Theorem 9 take N terms c_0 to c_(N-1) with N at most n + 1.
The text had its last parts near 2^(-2j-320). The last of eight parts of 1 - r^2/2 is about u^6 r^2 / 2, near 2^(-2j-319).
The unit, the crate's OD::EPS, was used in a caption and a remark and never defined.
The trigonometric functions run DWTimesDW3 and exp and ln DWTimesDW2. The text now says how they differ and that each appendix's constants are those of its product.
Table I named the operand x for the sine, cosine and tangent and a elsewhere, and Table II listed the operations in another order than Table I.
Shewchuk for expansions, Moller and Knuth for TwoSum, Sterbenz for the exact subtractions and Payne and Hanek for the reduction of large arguments were used without a reference. The list is now in order of first citation, with page ranges for the three ACM articles, the Universal pull request's full title, the crate's version and commit, and the QD authors' release.
The number 3.5 is that of the HAL preprint, as the crate's comment says. The published article could not be opened to confirm its numbering.
Assume with a bare reference printed as Assume 6, and IEEEtran's paragraph headings printed labels a) to d) that nothing refers to. The appendices now write Under Assumption 6 and use an unlabeled run-in heading.
Figure 1's labels were about 5 pt after scaling, the appendix started mid-column, Table V floated two pages past its text, and two long inline chains were stretched across the column. The figure is redrawn larger, the appendix starts on a new page, the table moves before its section, and the chains are displays.
Lemma 33 wrote f_k for the real that the expansion F_k approximates, another use of f. It is now F_k with the superscript e that the lemma's other exact values carry.
The PDF of the notation, references and layout changes.
@nmoinvaz
nmoinvaz force-pushed the paper/referee-presentation branch from b31a0a4 to 989b669 Compare November 19, 2026 03:06
@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (paper/referee-campaign@003a09c). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             paper/referee-campaign     #115   +/-   ##
=========================================================
  Coverage                          ?   97.15%           
=========================================================
  Files                             ?       21           
  Lines                             ?    13794           
  Branches                          ?        0           
=========================================================
  Hits                              ?    13401           
  Misses                            ?      393           
  Partials                          ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nmoinvaz
nmoinvaz merged commit c0065ee into paper/referee-campaign Nov 19, 2026
38 checks passed
@nmoinvaz
nmoinvaz deleted the paper/referee-presentation branch November 19, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant