Skip to content

release: finish a release that a cancelled run tagged - #119

Merged
nmoinvaz merged 2 commits into
mainfrom
ci/release-reuse-tag
Nov 20, 2026
Merged

nmoinvaz merged 2 commits into
mainfrom
ci/release-reuse-tag

Conversation

@nmoinvaz

@nmoinvaz nmoinvaz commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

A release run cancelled right after it pushed the version bump and the 5.0.0 tag left a release that no later run could finish, because git tag failed on the existing tag. A second run dispatched a second later lost the race to push main and failed.

  • The workflow runs in a release concurrency group, so a second dispatch waits for the running one instead of racing it, and the "Bump version" job checks out the branch's tip when it starts rather than the commit it was dispatched at, so a queued run builds on the first one's bump.
  • "Commit and tag" reuses an existing tag when HEAD descends from it and the tag's Cargo.toml has the version, since the test, release and crate jobs check out the tag. Any other tag of that name fails the job. Once this is merged, dispatching 5.0.0 again releases ddf5291.

@nmoinvaz nmoinvaz added the continuous integration CI/CD stack label Nov 19, 2026
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 66 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: c0dffbb4-5618-48ea-bf20-c6c9ba091af1
Commits

Reviewing files that changed from the base of the PR and between ddf5291 and 275afd8.

Files selected for processing: 1

  • .github/workflows/release.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@nmoinvaz
nmoinvaz force-pushed the ci/release-reuse-tag branch from b450249 to 11309c2 Compare November 19, 2026 20:57
@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The changes affect the manually dispatched release workflow and its publishing path.

The queued release must check out the latest branch tip before this is ready to merge.

Findings

  1. P1 Queued releases use stale commits ▶

Summary

The release workflow now queues overlapping runs and reuses an existing version tag when it points to the current commit.

  • Release runs now wait instead of racing each other.
  • A release reuses its version tag when it already marks HEAD.

Reviews (1) · Last reviewed commit: "release: reuse the tag that a cancelled ..." · Reviewed by Greptile

Comment thread .github/workflows/release.yml Resolved
Two dispatches of the release workflow raced to push the version bump, and the one that lost failed. A second
dispatch now waits for the running one and bumps the branch's tip when it starts, not the commit it was
dispatched at.
A run cancelled after pushing the version bump and its tag left a release that no later run could finish, since
tagging again failed. The tag is now reused when HEAD descends from it and its crate has the version, and any
other tag of that name still fails the job.
@nmoinvaz
nmoinvaz force-pushed the ci/release-reuse-tag branch from 11309c2 to 275afd8 Compare November 19, 2026 21:03
@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.72%. Comparing base (ddf5291) to head (275afd8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   97.26%   95.72%   -1.55%     
==========================================
  Files          22       22              
  Lines       14040    13530     -510     
==========================================
- Hits        13656    12951     -705     
- Misses        384      579     +195     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nmoinvaz
nmoinvaz merged commit 63dd4a1 into main Nov 20, 2026
38 checks passed
@nmoinvaz
nmoinvaz deleted the ci/release-reuse-tag branch November 20, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant