Repository navigation
jet: sum a session's Taylor step at the one coefficient it keeps - #42
Merged
Merged
Conversation
The session summed each step's whole jets by Horner's rule and kept coefficient j, so every order paid N coefficients per term. A jet's Horner step works coefficient by coefficient, so the session now sums coefficient j alone in the value lanes, with the same bits.
The row comparison stopped at the shorter residual, and the call sequence check passed with no endpoint calls recorded. Rows of unequal length now all count as differing, both endpoint maps must be called, and controls drop the right endpoint's calls and one Taylor step's.
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 39 minutes. View limit details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 97.15% 97.15%
=======================================
Files 12 12
Lines 2282 2283 +1
=======================================
+ Hits 2217 2218 +1
Misses 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up to #41 addresses CodeRabbit's three findings there.
JetSessionsummed each Taylor step's whole jets by Horner's rule and then kept only coefficient j, so every order paid N coefficients per term. A jet's Horner step multiplies and adds coefficient by coefficient, in the same arithmetic as the value lanes, so the session now sums coefficient j alone overP::field_coefvalues. The session test still matchesresidual_jetbit for bit at every order in double-, quad- and octo-double, with and without threads.The tests had two gaps.
bits_differ_counts_missing_rowschecks that.