Skip to content

jet: sum a session's Taylor step at the one coefficient it keeps - #42

Merged
nmoinvaz merged 2 commits into
mainfrom
fix/jet-session-review
Nov 16, 2026
Merged

nmoinvaz merged 2 commits into
mainfrom
fix/jet-session-review

Conversation

@nmoinvaz

Copy link
Copy Markdown
Owner

This follow-up to #41 addresses CodeRabbit's three findings there.

JetSession summed each Taylor step's whole jets by Horner's rule and then kept only coefficient j, so every order paid N coefficients per term. A jet's Horner step multiplies and adds coefficient by coefficient, in the same arithmetic as the value lanes, so the session now sums coefficient j alone over P::field_coef values. The session test still matches residual_jet bit for bit at every order in double-, quad- and octo-double, with and without threads.

The tests had two gaps.

  • The row comparison stopped at the shorter residual. Rows of unequal length now all count as differing, and bits_differ_counts_missing_rows checks that.
  • The call-sequence check passed even with no endpoint calls recorded. It now requires both endpoint maps' calls, and its controls drop the right endpoint's calls and one Taylor step's calls. Both controls fail the contract.

The session summed each step's whole jets by Horner's rule and kept
coefficient j, so every order paid N coefficients per term. A jet's
Horner step works coefficient by coefficient, so the session now sums
coefficient j alone in the value lanes, with the same bits.
The row comparison stopped at the shorter residual, and the call
sequence check passed with no endpoint calls recorded. Rows of unequal
length now all count as differing, both endpoint maps must be called,
and controls drop the right endpoint's calls and one Taylor step's.
@nmoinvaz nmoinvaz added the enhancement New feature or request label Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 66 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: ecb30f95-a522-43c2-bad6-6c54f977d3ec
Commits

Reviewing files that changed from the base of the PR and between 86db120 and 191b1cc.

Files selected for processing: 2

  • src/jet.rs
  • tests/jet_session.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@nmoinvaz
nmoinvaz merged commit c24118e into main Nov 16, 2026
15 checks passed
@nmoinvaz
nmoinvaz deleted the fix/jet-session-review branch November 16, 2026 06:17
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.15%. Comparing base (86db120) to head (191b1cc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files          12       12           
  Lines        2282     2283    +1     
=======================================
+ Hits         2217     2218    +1     
  Misses         65       65           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant