Skip to content

jet: give the series of a branch the session through jet_orders - #43

Merged
nmoinvaz merged 3 commits into
mainfrom
feat/jet-orders
Nov 16, 2026
Merged

nmoinvaz merged 3 commits into
mainfrom
feat/jet-orders

Conversation

@nmoinvaz

Copy link
Copy Markdown
Owner

multisolver 0.1.1 lets a problem hand the series of a branch its residual orders one at a time, through ResidualJet::jet_orders. This PR has the layout hand over its JetSession there, and moves to multidouble 4.7.0, which has the order-k jet operations (cs_at, mul_at, div_at, ...) that equations need to form one order from the orders kept.

Equations gains ORDER_BY_ORDER, false by default. Equations set it when their taylor_coeffs_at, left_state_at and right_state_at form one order from the kept ones. The layout's jet_orders then returns a JetSession on jets of 8, 16 or 32 coefficients, the smallest that holds the series' orders, so multisolver::anm::series pays about one order per call. Without the flag it returns multisolver's Recompute as before, because a session over the default methods would recompute every order at the full jet length and cost more than residual_jet.

The new test anm_series_through_the_session_is_bitwise runs Cylinder's branch of order 10 two ways, through a wrapper that sets the flag and through the plain equations. The two series match bit for bit at every order, with and without threads. The control anm_series_control_stale_session_differs leaves order k as it was with z_k zero (Control::JetStale), and 873 coefficients then differ. All 197 tests pass with --features mutate.

The PR also drops the crate documentation's stale "under construction (0.1.0, not published)" line.

multisolver 0.1.1 gives ResidualJet::jet_orders, through which the
series of a branch takes the residual's orders one at a time, and
multidouble 4.7.0 the order-k jet operations that equations need to
form one order from the kept ones.
Equations gains ORDER_BY_ORDER, set by equations whose order-k methods
form one order from the kept ones. The layout's jet_orders then returns
its JetSession on jets of 8, 16 or 32 coefficients, so that
multisolver's anm::series pays about one order per call, and otherwise
multisolver's Recompute as before.
The crate documentation still called it unpublished at 0.1.0, though
it is on crates.io.
@nmoinvaz nmoinvaz added the enhancement New feature or request label Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 54 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 66 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 6c582c60-ca6f-4d2d-bf4b-06a912ea72a0
Commits

Reviewing files that changed from the base of the PR and between c24118e and 4f0730e.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 6

  • Cargo.toml
  • src/equations.rs
  • src/jet.rs
  • src/lib.rs
  • src/shooting.rs
  • tests/anm.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.78%. Comparing base (c24118e) to head (4f0730e).

Files with missing lines Patch % Lines
src/shooting.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   97.15%   97.78%   +0.62%     
==========================================
  Files          12       12              
  Lines        2283     2298      +15     
==========================================
+ Hits         2218     2247      +29     
+ Misses         65       51      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nmoinvaz

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nmoinvaz
nmoinvaz merged commit cf91ac1 into main Nov 16, 2026
17 checks passed
@nmoinvaz
nmoinvaz deleted the feat/jet-orders branch November 16, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant