Repository navigation
feat: take ANM's residual orders one at a time from jet_orders - #1
Merged
Merged
Conversation
The series of a branch evaluated the residual's whole series again at every order, so a problem had no way to keep its lower orders. ResidualJet gains jet_orders, a session that returns order k once z_(k-1) is given, by default by residual_jet as before, and anm::series takes its orders from it.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anm::seriescalledresidual_jetwith every coefficient vector at every order, so each order recomputed all the lower ones and a series of order N cost N evaluations of growing length. A problem had no way to keep its lower orders between calls.ResidualJetgains a provided methodjet_orders, which returns aJetOrderssession: eachnext(z)call takes the newest coefficient vector z_(k-1) and returns order k of the residual's series with z_k left out, the right-hand side of the order-k solve. The default,Recompute, does exactly whatseriesdid before, so every existing problem gives the same bits. A problem that keeps its lower orders between calls overridesjet_ordersand makes the series cost N orders.The new test
anm_takes_the_orders_from_jet_ordersgives the planted polynomial branch a session that keeps each unknown's coefficients and its square's between calls, and redoes the square's order k - 1 once z_(k-1) is known. Its series matches theresidual_jetseries bit for bit in double- and quad-double. The control drops that redo, and the series then differs from order 2 on.Summary by CodeRabbit