http: don't throw in isValidConnectPath

Author: efekrskl

lib/_http_client.js

@@ -60,7 +60,7 @@ const {
 const Agent = require('_http_agent');
 const { Buffer } = require('buffer');
 const { defaultTriggerAsyncIdScope } = require('internal/async_hooks');
-const { URL, urlToHttpOptions, isURL } = require('internal/url');
+const { URL, URLParse, urlToHttpOptions, isURL } = require('internal/url');
 const {
   kOutHeaders,
   kNeedDrain,
@@ -196,23 +196,18 @@ function authoritiesMatch(canonicalHost, hostFromHeader) {
 
 function isValidConnectPath(path) {
   const match = CONNECT_PATH_REGEX.exec(path);
-  if (match === null) {
+  if (match === null || +match[2] === 0) {
     return false;
   }
 
-  try {
-    validatePort(match[2], 'options.path', false);
-    const url = new URL(`http://${path}`);
-
-    return url.hostname !== '' &&
-      url.username === '' &&
-      url.password === '' &&
-      url.pathname === '/' &&
-      url.search === '' &&
-      url.hash === '';
-  } catch {
-    return false;
-  }
+  const url = URLParse(`http://${path}`);
+  return url !== null &&
+    url.hostname !== '' &&
+    url.username === '' &&
+    url.password === '' &&
+    url.pathname === '/' &&
+    url.search === '' &&
+    url.hash === '';
 }
 
 // https://datatracker.ietf.org/doc/html/rfc9112#section-3.2