Skip to content

src: replace snapshot flag with affects_annotation - #62930

Closed
watilde wants to merge 2 commits into
nodejs:mainfrom
watilde:snapshot-todo
Closed

watilde wants to merge 2 commits into
nodejs:mainfrom
watilde:snapshot-todo

Conversation

@watilde

@watilde watilde commented Apr 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

Comment thread src/node_snapshotable.cc Outdated
@watilde watilde changed the title lib: detect --frozen-intrinsics mismatch when loading src: replace snapshot flag with affects_annotation Apr 25, 2026
@codecov

codecov Bot commented Apr 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.55556% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.64%. Comparing base (2428030) to head (2dc4329).
⚠️ Report is 973 commits behind head on main.

Files with missing lines Patch % Lines
src/node_options.cc 40.54% 21 Missing and 1 partial ⚠️
src/node_snapshotable.cc 58.82% 18 Missing and 3 partials ⚠️
src/node_options.h 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #62930    +/-   ##
========================================
  Coverage   89.63%   89.64%            
========================================
  Files         706      706            
  Lines      219219   219468   +249     
  Branches    42004    42074    +70     
========================================
+ Hits       196499   196740   +241     
+ Misses      14622    14621     -1     
- Partials     8098     8107     +9     
Files with missing lines Coverage Δ
src/node.h 92.30% <ø> (ø)
src/node_options-inl.h 83.39% <100.00%> (-0.31%) ⬇️
src/node_options.h 97.57% <85.71%> (-0.42%) ⬇️
src/node_snapshotable.cc 68.70% <58.82%> (-0.81%) ⬇️
src/node_options.cc 75.28% <40.54%> (-1.33%) ⬇️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.

@github-actions github-actions Bot closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants