Skip to content

src: add -f alias for --experimental-config-file - #62931

Closed
marco-ippolito wants to merge 1 commit into
nodejs:mainfrom
marco-ippolito:drop-default-and-alias
Closed

src: add -f alias for --experimental-config-file#62931
marco-ippolito wants to merge 1 commit into
nodejs:mainfrom
marco-ippolito:drop-default-and-alias

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Apr 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues and PRs related to Node.js configuration and feature settings. needs-ci PRs that need a full CI run. labels Apr 24, 2026
@JakobJingleheimer

JakobJingleheimer commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Hmm. I think -f is not intuitive (there are many more instances of -f meaning something else).

@joyeecheung

joyeecheung commented Apr 24, 2026

Copy link
Copy Markdown
Member

Personally I'd think -f is short for --format which seems common in other CLI tools

@marco-ippolito

marco-ippolito commented Apr 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Well, I took Docker as inspiration that uses -f to specificy the location of the Dockerfile. I'm open to suggestion for a single char alias

@bakkot

bakkot commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

Seems weird to have a short alias for an experimental flag. If people are writing node -f they'll have no reason to think that they're doing something experimental.

@marco-ippolito

marco-ippolito commented Apr 25, 2026

Copy link
Copy Markdown
Member Author

It emits an experimental warning

@GeoffreyBooth

GeoffreyBooth commented Apr 25, 2026

Copy link
Copy Markdown
Member

I don't think we should have a short flag for an experimental long flag.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.

@github-actions github-actions Bot closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. config Issues and PRs related to Node.js configuration and feature settings. needs-ci PRs that need a full CI run. stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marco-ippolito @nodejs-github-bot @JakobJingleheimer @joyeecheung @bakkot @GeoffreyBooth