crypto,quic: add NULL checks for OpenSSL allocation functions

[armorbreak001]

Fixes: #62774

This PR adds graceful NULL checks for OpenSSL allocation function return values, replacing CHECK() assertions that would abort the process on allocation failure.

Changes

src/crypto/crypto_aes.cc — AES_Cipher()

Replaced CHECK(ctx) with:

if (!ctx) {
  return WebCryptoCipherStatus::FAILED;
}

This matches the pattern already used in AES_CTR_Cipher2() in the same file.

src/crypto/crypto_cipher.cc — CipherBase::CommonInit()

Replaced CHECK(ctx_) with:

if (!ctx_) {
  return ThrowCryptoError(env(),
                          mark_pop_error_on_return.peekError(),
                          "Failed to allocate cipher context");
}

This matches the error handling pattern used elsewhere in the same function.

Note on other locations from #62774

• AES_CTR_Cipher2() — Already has a proper if (!ctx) check (line 238)
• TLSSession::Initialize() — Already has a proper if (!ssl) check (line 794)
• ECKeyExportTraits::DoExport() — This function no longer exists in the current codebase; the EC key handling code has been refactored

[nodejs-github-bot]

Review requested:

• @nodejs/crypto

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73487/

[codecov]

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (5d578c5) to head (1fb33d5).
⚠️ Report is 659 commits behind head on main.

Files with missing lines	Patch %	Lines
src/crypto/crypto_cipher.cc	0.00%	2 Missing and 1 partial ⚠️
src/crypto/crypto_aes.cc	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63040      +/-   ##
==========================================
+ Coverage   89.65%   90.05%   +0.39%     
==========================================
  Files         708      714       +6     
  Lines      220402   225525    +5123     
  Branches    42269    42642     +373     
==========================================
+ Hits       197597   203087    +5490     
+ Misses      14671    14205     -466     
- Partials     8134     8233      +99     

Files with missing lines	Coverage Δ
src/crypto/crypto_aes.cc	53.63% <0.00%> (-0.19%)	⬇️
src/crypto/crypto_cipher.cc	77.13% <0.00%> (-0.31%)	⬇️

... and 150 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[armorbreak001]

Hi @nodejs/crypto team — just wanted to follow up on this PR. It adds NULL checks for OpenSSL allocation functions in crypto_aes.cc and crypto_cipher.cc, which could prevent potential crashes on allocation failure.

I understand the team is busy. If there are any changes needed or if this isn't the right approach, I'm happy to adjust. Thanks for your time!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/74572/

[jasnell]

@armorbreak001 ... as a general rule, please do not try to add empty commits to trigger CI. It doesn't work.

[armorbreak001]

@jasnell Understood, my apologies for that. Won't do it again — I'll wait for CI to pick up changes naturally. Thanks for the approval and for letting me know.

[jasnell]

This needs a rebase

[armorbreak001]

Thanks for the heads-up! I checked the latest upstream/main and it looks like these NULL checks have already been applied (both src/crypto/crypto_aes.cc:51 and src/crypto/crypto_cipher.cc:346 now have the proper null guards).

Closing this PR as superseded — the fix made it in! 🎉

[armorbreak001]

Superseded — fix already present in main