Conversation
Collaborator
|
Review requested:
|
avivkeller
approved these changes
Jul 14, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64376 +/- ##
==========================================
- Coverage 90.23% 90.11% -0.12%
==========================================
Files 741 741
Lines 241194 242164 +970
Branches 45432 45576 +144
==========================================
+ Hits 217640 218234 +594
- Misses 15129 15441 +312
- Partials 8425 8489 +64
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
UditDewan
force-pushed
the
fix-run-isolation-none-patterns
branch
from
July 22, 2026 05:45
60aba6b to
a0cf638
Compare
Member
|
This needs a rebase |
Since run() applies testNamePatterns and testSkipPatterns to the root test configuration under isolation 'none', the file level test that wraps the single spawned process in watch mode is filtered by name itself. Its name is empty, so any name pattern filtered it out and no test ever ran. The same happens on the CLI with `--test --watch --test-isolation=none --test-name-pattern=...`. Exempt file wrappers from name filtering, as is already done for tag filtering: the patterns are applied to the tests inside of the file by the child process. Refs: nodejs#64359 Refs: nodejs#62269 Signed-off-by: uditDewan <udit.dewan21@gmail.com>
UditDewan
force-pushed
the
fix-run-isolation-none-patterns
branch
from
September 14, 2026 18:04
a0cf638 to
5b60677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
run()validatestestNamePatternsandtestSkipPatternsand forwards them to spawned processes as--test-name-pattern/--test-skip-patternflags, but never applies them to the root test's configuration. Withisolation: 'none'there are no spawned processes — the test files are imported into the current process — so both options were silently ignored and every test ran.The same filters do work as CLI flags under
--test-isolation=nonebecause the test runner entry point passes the memoizedparseCommandLine()options object torun(), which spreads it into the root configuration.Fix
Apply the validated patterns to the root test configuration when
isolationis'none'.Doing only that would break watch mode with
isolation: 'none', where a file level test with an empty name wraps the single spawned process: the name filter would reject it and no test would ever run. The equivalent breakage is observable today on the CLI, wherenode --test --watch --test-isolation=none --test-name-pattern=...runs nothing. Since aFileTestrepresents a test file rather than a named test — the patterns are applied to the tests inside the file by the spawned process — it is now exempt from name filtering, likeTestHookalready is.Fixes: #64359