Skip to content

deps: V8: hot-patch fix for Temporal cherry-pick cd89fe6f7acb - #65992

Draft
srl295 wants to merge 1 commit into
nodejs:mainfrom
srl295:temporal-issue-62676
Draft

deps: V8: hot-patch fix for Temporal cherry-pick cd89fe6f7acb#65992
srl295 wants to merge 1 commit into
nodejs:mainfrom
srl295:temporal-issue-62676

Conversation

@srl295

@srl295 srl295 commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #62676

Original commit message:

build: Fix Temporal compilation with system or no ICU

- remove reference to internal udatamem.h header file

See: https://unicode-org.atlassian.net/browse/ICU-23400
See: Node: https://github.com/nodejs/node/issues/62676
See: V8: https://chromium-review.googlesource.com/c/v8/v8/+/8281487

Bug: 8281487

Refs: srl295/v8@cd89fe6

See: https://unicode-org.atlassian.net/browse/ICU-23400
See: Node: #62676
See: V8: https://chromium-review.googlesource.com/c/v8/v8/+/8281487

@srl295
deps: V8: cherry-pick cd89fe6f7acb
8ebe149 
Original commit message:

    build: Fix Temporal compilation with system or no ICU

    - remove reference to internal udatamem.h header file

    See: https://unicode-org.atlassian.net/browse/ICU-23400
    See: Node: nodejs#62676
    See: V8: https://chromium-review.googlesource.com/c/v8/v8/+/8281487

    Bug: 8281487

Refs: srl295/v8@cd89fe6
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 11, 2026
@srl295 srl295 self-assigned this Sep 11, 2026
@srl295 srl295 added wip Issues and PRs that are still a work in progress. deprecations Issues and PRs related to deprecations. and removed deprecations Issues and PRs related to deprecations. labels Sep 11, 2026
@srl295
srl295 requested a review from aduh95 September 11, 2026 22:07
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77384/

This was referenced Sep 17, 2026
Open
Closed
legendecas
legendecas reviewed Sep 17, 2026
View reviewed changes

@legendecas legendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check can be removed (in a new commit):

node/configure.py

Lines 2264 to 2266 in 6a7f94c

case 'system-icu':
warn('Temporal support disabled when compiling with a shared ICU library')
options.v8_disable_temporal_support = True

@srl295

srl295 commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

This check can be removed (in a new commit):

node/configure.py

Lines 2264 to 2266 in 6a7f94c

case 'system-icu':
warn('Temporal support disabled when compiling with a shared ICU library')
options.v8_disable_temporal_support = True

Good catch. Thanks.

I will be setting a new v8 option there anyway, so makes sense. Hope to have a new patch tomorrow.

@legendecas

legendecas commented Sep 17, 2026

Copy link
Copy Markdown
Member

Thank you, I verified this locally and node works with a brew provided icu4c shared library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas left review comments
@joyeecheung joyeecheung Awaiting requested review from joyeecheung
@richardlau richardlau Awaiting requested review from richardlau
@aduh95 aduh95 Awaiting requested review from aduh95

At least 1 approving review is required to merge this pull request.

Assignees

@srl295 srl295

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. wip Issues and PRs that are still a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Temporal does not compile with shared ICU or no ICU

3 participants

@srl295 @nodejs-github-bot @legendecas