Skip to content

fs: preserve rmSync errno for filesystem errors - #65999

Draft
icecold009 wants to merge 1 commit into
nodejs:mainfrom
icecold009:codex/nodejs-rmsync-errno
Draft

fs: preserve rmSync errno for filesystem errors#65999
icecold009 wants to merge 1 commit into
nodejs:mainfrom
icecold009:codex/nodejs-rmsync-errno

Conversation

@icecold009

Copy link
Copy Markdown

Summary

  • Preserve errno values from std::filesystem failures in fs.rmSync().
  • Add Linux regression coverage for EINVAL from a trailing-dot path.

Fixes: #65884

Tests

  • node --check test/parallel/test-fs-rm.js
  • git diff --check

The full Node.js test could not run on this Windows host because symlink creation is denied, and this sparse checkout has no native build output.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Sep 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@icecold009
icecold009 force-pushed the codex/nodejs-rmsync-errno branch from 8a55339 to e8b9dde Compare September 12, 2026 11:28
Signed-off-by: Shaurya Saria <sariashaurya09@gmail.com>
@icecold009
icecold009 force-pushed the codex/nodejs-rmsync-errno branch from e8b9dde to 0856f42 Compare September 12, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs: rmSync() reports UV_UNKNOWN with an empty code for unmapped errno values

2 participants