Skip to content

test: deflake test-run-watch-cwd-isolation-none-* - #66035

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:test-watch-flakes
Open

aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:test-watch-flakes

Conversation

@aduh95

@aduh95 aduh95 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Before this PR, on my machine:

$ tools/test.py --repeat 999 test/test-runner/test-run-watch-cwd-isolation-none.mjs test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs
[…]
[00:57|% 100|+ 1364|- 634]: Done
[…]

With this PR:

$ tools/test.py --repeat 999 test/test-runner/test-run-watch-cwd-isolation-none.mjs test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs
[01:03|% 100|+ 1998|-   0]: Done                                          

All tests passed.

Refs: #54534

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 15, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 changed the title test: fix test-run-watch flakiness test: deflake test-run-watch-cwd-isolation-none-* Sep 15, 2026
@panva panva added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Sep 15, 2026
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (7203d9b) to head (0abbbe5).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66035      +/-   ##
==========================================
+ Coverage   89.61%   90.22%   +0.60%     
==========================================
  Files         789      789              
  Lines      270476   270613     +137     
  Branches    51619    51798     +179     
==========================================
+ Hits       242393   244155    +1762     
+ Misses      18449    16937    -1512     
+ Partials     9634     9521     -113     

see 130 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva

panva commented Sep 15, 2026

Copy link
Copy Markdown
Member

Drop the test/common/watch.js changes and it should be good to go. Plus an update to test/test-runner/test-runner.status is due

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95

aduh95 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author
00:05:07.232 not ok 1395 test-runner/test-run-watch-cwd-isolation-none
00:05:07.232   ---
00:05:07.232   duration_ms: 729.99900
00:05:07.233   severity: fail
00:05:07.233   exitcode: 1
00:05:07.233   stack: |-
00:05:07.233   ...

Humpf failure on Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants