Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
SQLite re-invokes xFilter on a cursor it already used, as it does for the inner table of a correlated subquery or join, abandoning the previous iterator mid-loop. Call its return() method so generator `finally` blocks still run. Refactor the xClose cleanup intoCloseIterator() so both paths share it; on refilter, a throwing cleanup is surfaced as the query error. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: opencode
trivikr
force-pushed
the
sqlite-virtual-table-cursor-2
branch
from
September 22, 2026 05:59
9b01002 to
cefe77f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66195 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.02%
==========================================
Files 790 790
Lines 272508 272515 +7
Branches 52028 52037 +9
==========================================
- Hits 246071 246040 -31
- Misses 16905 16949 +44
+ Partials 9532 9526 -6
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
Author
|
This CI is successful. If this PR is approved with no changes requested, I'll land it manually. |
trivikr
added
the
author ready
panva
approved these changes
Sep 25, 2026
panva
pushed a commit
that referenced
this pull request
Sep 25, 2026
SQLite re-invokes xFilter on a cursor it already used, as it does for the inner table of a correlated subquery or join, abandoning the previous iterator mid-loop. Call its return() method so generator `finally` blocks still run. Refactor the xClose cleanup intoCloseIterator() so both paths share it; on refilter, a throwing cleanup is surfaced as the query error. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: opencode PR-URL: #66195 Fixes: #66193 Reviewed-By: Guilherme Araújo <arauujogui@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Member
|
Landed in 8bf65d4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66193
SQLite re-invokes xFilter on a cursor it already used, as it does for the inner table of a correlated subquery or join, abandoning the previous iterator mid-loop. Call its return() method so generator
finallyblocks still run.Refactor the xClose cleanup into CloseIterator() so both paths share it; on refilter, a throwing cleanup is surfaced as the query error.
Assisted-by: opencode