ffi: use type errors for invalid signatures - #66222
Open
HoonDongKang wants to merge 1 commit into
Open
HoonDongKang wants to merge 1 commit into
HoonDongKang wants to merge 1 commit into
Conversation
Signed-off-by: HoonDongKang <d159123@naver.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66222 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.01%
==========================================
Files 790 790
Lines 272880 272880
Branches 52103 52104 +1
==========================================
- Hits 246385 246377 -8
- Misses 16936 16970 +34
+ Partials 9559 9533 -26
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseFunctionSignature()reportsERR_INVALID_ARG_VALUEwhen signature properties have incorrect JS types.Use
ERR_INVALID_ARG_TYPEwhen:returnis not a string.argumentsis not an array.argumentsarray is not a string.Testing