node-api: find the Environment once - #66509
Draft
nigrosimone wants to merge 1 commit into
Draft
nigrosimone wants to merge 1 commit into
nigrosimone wants to merge 1 commit into
Conversation
Without an async context, napi_make_callback went through the public node::MakeCallback(), which looks up the Environment from the creation context of the callback on every call. The napi_env already knows it, so call into it directly, as the path with an async context does. node_napi_env__::node_env() also looked it up from the context on every call: find it once, a napi_env lives as long as its Environment. Add a benchmark, napi/make_callback_napi. Refs: nodejs/performance#24 Signed-off-by: Nigro Simone <nigro.simone@gmail.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without an async context,
napi_make_callbackgoes through the publicnode::MakeCallback(), which looks up the Environment from the creation context of the callback on every call. The napi_env already knows it, so call into it directly, as the path with an async context does.node_napi_env__::node_env()also looked it up from the context on every call (also incan_call_into_js()): now it is found once, a napi_env lives as long as its Environment.There was no benchmark for
napi_make_callback, so this addsnapi/make_callback_napi, a C addon calling it from a libuv timer like an I/O callback.Draft because on main alone the gain is inside the noise (26.3.0 + #66316: -3.0% and +2.1%, no stars). With #66395 and #66500 underneath it is +15% (200 to 174 ns), compare.js, 30 runs, Linux x64, one core:
The Node-API callback tests and the make-callback addon tests pass. Part of the plan in nodejs/performance#24.
Disclosure: I used Opus 5.5 (Max) as coding assistant