fix: remove old courses - #9172
Open
bmuenzenmeyer wants to merge 3 commits into
Open
bmuenzenmeyer wants to merge 3 commits into
bmuenzenmeyer wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9172 +/- ##
==========================================
+ Coverage 86.04% 86.07% +0.03%
==========================================
Files 86 86
Lines 6046 6041 -5
Branches 358 357 -1
==========================================
- Hits 5202 5200 -2
+ Misses 840 837 -3
Partials 4 4 ☔ View full report in Codecov by Harness. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update related navigation types, fixtures, and locale bundles before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Removes the obsolete Courses/Certification navigation link and English translation.
Changes:
- Removes the certification navigation entry.
- Removes the English certification label.
| File | Review summary |
|---|---|
packages/i18n/src/locales/en.json |
English key removed, but stale keys remain in enabled non-English locale bundles. |
apps/site/navigation.json |
Navigation entry removed, but related types and Storybook fixtures still reference it. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
📦 Build Size ComparisonSummary
Changes🔄 Modified Routes (4)
|
AugustinMauroy
approved these changes
Sep 24, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
bmuenzenmeyer
commented
Sep 24, 2026
avivkeller
approved these changes
Sep 24, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes courses (changed a while ago from certifications), per OpenJS Marketing.
Ref: https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1790193830860619?thread_ts=1789646685.248329&cid=CVAMEJ4UV
Validation
Ran locally. Check preview.
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.