Repository navigation
fix: refuse untrusted globals when loading model checkpoints (v0.47.2) - #316
Merged
Merged
Conversation
Demucs package files are pickles that store the model class, and were loaded with torch.load(weights_only=False), so a crafted .th file could run code at load time. Load them through a restricted unpickler that only resolves the globals real Demucs v4 packages use (verified byte-identical against all 7 published checkpoints). Pass weights_only=True explicitly on the VR, MDXC, RoFormer and MDX mixer loads, which were only safe by default on torch >= 2.6, and drop the RoFormer legacy fallback that retried without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012RYLVTA9CYSnmncNv3GRHJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.th) were loaded withtorch.load(weights_only=False). They're pickles that store the model class, so a crafted file could run code at load time. They now load through a restricted unpickler that only resolves the globals real Demucs v4 packages use.weights_only=Trueexplicitly. Before this they were only safe by default on torch >= 2.6, and our range allows 2.3. The RoFormer legacy fallback that retried withoutweights_onlyis removed.Verification
.thcarrying anos.systempayload is refused and the payload never runs.tests/unit/test_demucs_safe_load.py; updated mocks intest_directml.pyandtest_model_reuse.py. Unit suite: 560 passed. The 2test_mps_native_fp16failures also happen on main.@coderabbitai ignore
🤖 Generated with Claude Code
https://claude.ai/code/session_012RYLVTA9CYSnmncNv3GRHJ