Skip to content

Release v0.8.1 - #56

Merged
hitalin merged 2 commits into
mainfrom
develop
Aug 4, 2026
Merged

Release v0.8.1#56
hitalin merged 2 commits into
mainfrom
develop

Conversation

@hitalin

@hitalin hitalin commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

v0.8.0 のレビュー指摘修正(#55)。v0.8.0 は使わず本リリースを使うこと。

修正内容

  • TimelineKey::parseBasic 名を lowercase kebab に限定 🔒 — Basic 名が API パス (notes/{t}-timeline) へ補間されるため、/ . ? # を含む名前でリクエスト先を差し替えられた(daemon の /timeline/{tl_type} と CLI から到達可能)
  • per-timeline トリムの writer lock をチャンクごとに解放 🚀 — tx だけ分割して Mutex を保持していたため、初回トリム中は全書込がブロックされていた
  • HTTP エラーアダプタを safe_message() 経由に 🔒 — Internal / Database の内部詳細がレスポンスに出得た
  • cache sweepOutputFormat を尊重 — json/ids で機械可読な出力を返す
  • CLAUDE.md のエラー型表記を実装に合わせて訂正(NotecliErrorNoteDeckError

v0.8.0 からの移行

DB スキーマ(V6)に変更はないため、v0.8.0 を適用済みの DB もそのまま使える。v0.7.0 以前からの更新時の注意は v0.8.0 のリリースノートを参照。

🤖 Generated with Claude Code

hitalin and others added 2 commits August 4, 2026 09:00
PR #54 のレビューで挙がった 4 件を修正する。

- **TimelineKey::parse の Basic 名を lowercase kebab に限定** (security):
  Basic 名は `notes/{t}-timeline` として API パスへ補間されるため、`/` `.`
  `?` `#` 等を含む名前でリクエスト先を差し替えられた
  (例: `../../admin/x?` → `/api/admin/x` にトークン付きで到達)。daemon の
  `GET /timeline/{tl_type}` と CLI から到達可能だった
- **per-timeline トリムがチャンクごとに writer lock を解放するよう修正**:
  tx だけ分割して Mutex を握りっぱなしだったため、1M 行規模の初回トリム中は
  ingest_notes 等すべての書込が完走まで待たされていた (チャンク分割の目的が
  達成できていなかった)
- **HTTP エラーアダプタを safe_message() 経由に**: `Internal` / `Database` の
  内部詳細がそのままレスポンスに出得た
- **`cache sweep` が OutputFormat を尊重するよう修正**: json/jsonl/ids で
  機械可読でない出力を返していた

CLAUDE.md のエラー型表記も実装に合わせて訂正 (NotecliError → NoteDeckError)。
バージョンを 0.8.1 にバンプ。

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fix: レビュー指摘の修正 (path traversal / writer lock / safe_message)
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@hitalin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f919043c-23fe-4852-befd-f59e796779f8

📥 Commits

Reviewing files that changed from the base of the PR and between b051a7f and 163004b.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • CLAUDE.md
  • Cargo.toml
  • src/commands/mod.rs
  • src/db.rs
  • src/http_server.rs
  • src/models.rs

Comment @coderabbitai help to get the list of available commands.

@hitalin hitalin self-assigned this Aug 4, 2026
@hitalin
hitalin merged commit 272edae into main Aug 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant